JS: Enable type extraction inside conditional types again #10202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erik-krogh
approved these changes
Aug 29, 2022
erik-krogh
added a commit
to erik-krogh/ql
that referenced
this pull request
Aug 30, 2022
…ge conflict between github#10202 and github#10184
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This re-enables type extraction inside conditional types, i.e. types of form
X extends Y ? A : B, which are relevant for extracting MaD typings from.d.tsfiles.This was originally disabled in #1295 to avoid divergence issues when extracting the type property graph. However, in #3781 we stopped extracting the type property graph entirely, so the previous mitigation should no longer be needed.
I verified that this code, which originally caused problems, still works after this change. Evaluation also looks fine.