Skip to content

Textually replace CodeQL version in package.json #2269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 1, 2024

Conversation

angelapwen
Copy link
Contributor

Textually replace CodeQL version in package.json instead of using npm version, which occasionally fails due to merge conflicts that arise in the package.json process.

I have tested the replace_version_package_json function locally against the current copy of package.json and it works as expected, only replacing the version number in the file.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

... instead of using `npm version`, which occasionally fails due to merge conflicts that arise in the `package.json` process.
@angelapwen angelapwen requested a review from a team as a code owner April 30, 2024 22:28
henrymercer
henrymercer previously approved these changes May 1, 2024
Copy link
Contributor

@henrymercer henrymercer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me!

@angelapwen angelapwen merged commit 41857ba into main May 1, 2024
@angelapwen angelapwen deleted the angelapwen/textual-replacement branch May 1, 2024 17:10
@github-actions github-actions bot mentioned this pull request May 8, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants