Skip to content

Add common CLI configuration error categories #2130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Feb 14, 2024
Merged

Add common CLI configuration error categories #2130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
c45840d
Add common CLI configuration error categories
angelapwen Feb 13, 2024
d51e49a
Drive-by: appease enum type warning
angelapwen Feb 13, 2024
9bc1f4d
Drive-by: tiny workflow improvement
angelapwen Feb 13, 2024
e45c9a6
Stop using exit code 32 for new category
angelapwen Feb 13, 2024
1e5200d
Actually wrap errors from autobuild command
angelapwen Feb 13, 2024
aeac6ec
Drive-by: more type appeasing
angelapwen Feb 13, 2024
7e39cda
Revert unnecessary casting
angelapwen Feb 13, 2024
8361861
Generalize exit code 32 to no code found error
angelapwen Feb 13, 2024
9b0da38
Update comment
angelapwen Feb 13, 2024
bddc0a0
Add logic to prepend docs link if necessary
angelapwen Feb 14, 2024
9f5ccaf
Use regex matching for tests with exit code 32
angelapwen Feb 14, 2024
435692c
Append additional error message instead of prepend
angelapwen Feb 14, 2024
a18a72e
Fix regex in tests: properly escape `.` character
angelapwen Feb 14, 2024
cefd39b
Correctly handle additional error message to append case
angelapwen Feb 14, 2024
e1e0ba3
Fold no source code found errors into one
angelapwen Feb 14, 2024
bce391b
Regex fixups
angelapwen Feb 14, 2024
3dc47a2
Rename `snippets` to `candidates` for clarity.
angelapwen Feb 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/debug-artifacts-failure.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ jobs:
shell: bash
run: |
LANGUAGES="cpp csharp go java javascript python"
pushd "./my-debug-artifacts"
cd "./my-debug-artifacts"
echo "Artifacts from run:"
for language in $LANGUAGES; do
echo "- Checking $language"
Expand All @@ -82,6 +82,5 @@ jobs:
exit 1
fi
done
popd
env:
GO111MODULE: auto
116 changes: 81 additions & 35 deletions lib/cli-errors.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/cli-errors.js.map
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading