Skip to content

Conversation

@aeisenberg
Copy link
Contributor

Update contributing guide. Ensure this workflow runs once a week.

@aeisenberg aeisenberg requested a review from a team as a code owner May 2, 2022 16:48
run: |
# Update the required checks based on the current branch.
# Typically, this will be main.
SHA="$(git rev-parse HEAD)"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder whether this would really work (there is no checkout step in the workflow, and HEAD may not work in a single-commit checkout). But I suppose we probably need to merge it before we can find out, as the branch protection rules probably would not allow repository updates from branches other than main.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm...now that I think about it, we can just get the SHA from the context. Let me change this.

Update contributing guide.
Ensure this workflow runs once a week.
@aeisenberg aeisenberg force-pushed the aeisenberg/update-checks branch from 27be06f to b71f20d Compare May 2, 2022 17:15
@aeisenberg
Copy link
Contributor Author

Thanks for the review. Going to merge this and run it to ensure it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants