-
Notifications
You must be signed in to change notification settings - Fork 415
Allow running packs with paths #1049
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b8e27d7 to
f86f601
Compare
Also, this cleans up our pack-related integration tests. We are now testing with the most recent CLIs.
f86f601 to
06b15c2
Compare
| # use tr to replace newlines with spaces and xargs to trim leading and trailing whitespace | ||
| RULES="$(cat javascript.sarif | jq -r '.runs[0].results[].ruleId' | sort | tr "\n" " " | xargs)" | ||
| RULES="$(cat javascript.sarif | jq -r '.runs[0].results[].ruleId' | sort | tr "\n" " " | tr "\r" " " | xargs)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this also works (first character of string1 maps to first character of string2, and the second to the second, and so on):
tr "\r\n" " "There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh...didn't know tr worked that way. Thanks.
|
I'm about to make a minor change to this PR and I will ask for another review. Thanks for looking. |
This will allow the command to resolve packs with paths. Also, use a more concise version of `tr`.
0120296 to
a73e506
Compare
|
Note that some required checks have been removed and that's why this is not mergeable. I am going to remove these as required checks and then recreate the list of required as described here: https://github.com/github/codeql-core/issues/1405#issuecomment-896190163 I'll make sure these instructions are easier to find. |
Also, use newer versions of the integration test packs that allow us to run with the latest CLI.
There are a few things of note here:
Merge / deployment checklist