This repository was archived by the owner on Jun 21, 2023. It is now read-only.
The indexed cache #384
Merged
The indexed cache #384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shana
force-pushed
the
shana/make-modelservice-return-observables
branch
4 times, most recently
from
244c728 to
d24080f
Compare
shana
force-pushed
the
shana/make-modelservice-return-observables
branch
from
03e3bc7 to
6d30774
Compare
Move gitignores and licenses lists to the indexed cache and have ModelService return observables of the cached data. The view model is responsible for whatever sorting/filtering/adding is required to make the list consumable by the view. Fix all the related tests.
Implement the repository listing with an indexed cache and add support for putting it into ITrackingCollection, so we can stream results instead of having object blobs.
shana
force-pushed
the
shana/make-modelservice-return-observables
branch
from
6d30774 to
9a03e88
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves everything into the indexed akavache cache so that all methods in
ModelServicereturnIObservable<T>and not readonly collections and other silly things, and everything is streamed directly to the database. This also means that each object returned from Octokit (PullRequest, Repository, User, etc) will be stored in one entry in the database, and all queries will share the objects (so if we do a query to get a single repository or pull request or any single object, it will return the object that was cached when we listed all of them)