Display a message when project isn't a git/github repository. #374
Conversation
To GitHub pane. XAML compiler crashing on compiling the view though :(
It was null on load, and works without it.
Seems you can't assign text directly to the `Content` of a subclass of `UserControl`.
…oller-properly' into fixes/356-not-a-github-repository Conflicts: src/GitHub.VisualStudio/UI/Views/GitHubPaneViewModel.cs
VM not actually doing anything yet though.
Shows the Team Explorer Sync page and opens the GitHub publish section.
When the GitHub pane is open and the project is not a git repository, display a (placeholder) message.
| Enterprise, | ||
| Other, | ||
| NonGitRepository, | ||
| } |
There was a problem hiding this comment.
Move the Other value up to the first position, or add a None value. enums always have a default value, and distinguishing between DotCom and haven't probed yet / this is a default is hard if they're the same value.
EDIT: maybe Unknown...
There was a problem hiding this comment.
Well strictly speaking, the Unknown state is RepositoryOrigin == null as the RepositoryOrigin property is currently nullable, because it came from the nullable IsGitHubRepo property. However I agree that it would be better the have that Unknown value as an enum value rather than the null state: will change.
|
The current messages look fine for now. We can refine them during the beta phase. |
|
⚽ back to you! |
Make the `RepositoryOrigin` property non-nullable and use `RepositoryOrigin.Unknown` as the unknown value.
|
Ok,.those changes made. |
|
|
We still need to decide on the wording for when the current Team Explorer context isn't a git repository.