This repository was archived by the owner on Jun 21, 2023. It is now read-only.
[Backport] Add directory validation #373
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I should probably hold off on picking the rest of this until the second part is complete. |
paladique
force-pushed
the
paladique/pick-dir-validation
branch
from
a7eed06 to
fa8fa82
Compare
paladique
force-pushed
the
paladique/pick-dir-validation
branch
from
fa8fa82 to
8766df6
Compare
paladique
force-pushed
the
paladique/pick-dir-validation
branch
from
e9d20fc to
849500c
Compare
paladique
changed the title
As we decided that it was clearer to write out validation conditions explicitly in the VM.
paladique
force-pushed
the
paladique/pick-dir-validation
branch
from
badd9d3 to
5d08171
Compare
Contributor
Author
|
Somehow after picking all commits from #369 it looks like there was still a reference to two files that didn't exist. I just removed them and tested to make sure everything was 👍 |
Contributor
|
This looks good! 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the upcoming hot-fix release listed in #368, it was decided that the resolution to #360 should be in this release. Picked those commits.