Initial support for collapsing in clone dialog. #288
Conversation
Makes groups in the clone dialog collapsible. If there is only a single group, then it will be expanded; as more groups are created, the first group is collapsed and further groups will be added collapsed. Only problem with this is that you can see an initial flash of expanded items when loading with multiple groups, however I felt this was preferable to everything being collapsed until the whole list is loaded...
|
This will obviously need a pass by @donokuda too because it's fugly as sin ;) |
|
@grokys I can polish this up today! Currently it looks like:
I did a quick mockup and thinking of moving towards something closer to this:
I'm going to start on this, but I am also open to feedback in the meantime. |
|
Looks great Don! |
|
I like it! ✨ |
Polish expander styles
|
Merged @donokuda polish and think this is now ready for review 💎 |
| } | ||
|
|
||
| static ListCollectionView CreateRepositoryListCollectionView(IEnumerable<IRepositoryModel> repositories) | ||
| ListCollectionView CreateRepositoryListCollectionView(IEnumerable<IRepositoryModel> repositories) |
There was a problem hiding this comment.
This could be a static method, right?
There was a problem hiding this comment.
It was static before, but now RepositoryGroupDescription needs a reference to the RepositoryCloneControl (i.e. this) in order to collapse the existing group when a second group is added.
There was a problem hiding this comment.
Ah! How did I not see this? 😆
Ok, carry on.
|
Looks good! I just had some really minor nitpicky feedback. Probably need to update this branch from master (or rebase it if you're feeling funky). |
|
🍵 |
Reformat xaml and set proper capitalization on style keys (we're using lower case for local styles). Set `readonly` and kill `private` with 🔥
|
I fixed some nitpicks regarding |
Fix for #276
Makes groups in the clone dialog collapsible. If there is only a single
group, then it will be expanded; as more groups are created, the first
group is collapsed and further groups will be added collapsed.
Only problem with this is that you can see an initial flash of expanded
items when loading with multiple groups, however I felt this was
preferable to everything being collapsed until the whole list is
loaded...