-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[wip] Fleshing out the data backend for PR creation #265
Conversation
| [PartCreationPolicy(CreationPolicy.NonShared)] | ||
| class PullRequestCreationViewModel : BaseViewModel, IPullRequestCreationViewModel | ||
| { | ||
| public PullRequestCreationViewModel(IRepositoryHost repositoryHost, ISimpleRepositoryModel repository) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The initialization code is failing because this constructor is not marked [ImportingConstructor], so MEF can't create an instance of this. Every class that's exported to MEF (marked with [Export..]) has to either have an empty public constructor or a constructor marked with [ImportingConstructor], so that MEF knows which constructor to invoke when instantiating things.
|
I figured out why this failed to run, I've added a comment about it. You can go ahead and revert the eddd987 commit, or better yet, reset history to the commit before it and force push so we don't have it in the history, it's not particularly useful. |
eddd987 to
f16b03c
Compare
a674c09 to
2af32c2
Compare
|
|
||
|
|
||
|
|
||
| public PullRequestCreationViewModel(IRepositoryHost repositoryHost, ISimpleRepositoryModel repository) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs [ImportingConstructor]
|
No luck with getting sample data to populate at runtime, @shana suggested a sample side project/experiment with a simple example to try to understand why this isn't successful. |
In an attempt to make it look a little crispier 🥚
|
Looks like the assignee list is populating with everyone from the whole org. |
|
Yeah, it should only be listing the actual repository members. Could you check which GitHub API would return that? It should be somewhere on the API reference page on the web. |
Searched the API for this, I'm currently using There is |
Yup, that's a good idea! |
|
Development of the PR Creation is now here |
Uh oh!
There was an error while loading. Please reload this page.