Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Conversation

@jcansdale
Copy link
Collaborator

@jcansdale jcansdale commented Jan 25, 2019

You can find a VSIX installer for this PR here:
https://ci.appveyor.com/api/buildjobs/cm5ipkqbus5g6ca0/artifacts/2.8.0.6611%2FGitHub.VisualStudio.vsix

What this PR does

Ensure that cancellationToken and progress arguments are propagated to the CloneAsync. This will make clone progress appear on the status bar when initiated via the Start Page (or Get to Code).

How to test

  1. Click the GitHub button on the Start Page

image

  1. Select a repository and click Clone

image

  1. Check progress appears on the status bar

image

Fixes #2196

Copy link

@prasethu prasethu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Tested and saw that it works great!

@prasethu
Copy link

Folks, any ETA on getting this merge? Thank you.

@jcansdale
Copy link
Collaborator Author

@prasethu is there a particular date we should aim for?

@jcansdale jcansdale merged commit fced2fe into master Jan 28, 2019
@jcansdale jcansdale deleted the fixes/2196-clone-progress branch January 28, 2019 16:50
@prasethu
Copy link

prasethu commented Jan 28, 2019

@jcansdale You've already merged it 👍

I can't speak exactly to release dates, but pretty soon - a month or so.

Would this be available as a release soon?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants