This repository was archived by the owner on Jun 21, 2023. It is now read-only.
Set RxApp.DefaultExceptionHandler. #2121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, exceptions thrown in `ReactiveCommand` execute methods would crash the application. Add a handler to `RxApp.DefaultExceptionHandler` to handle these exceptions and log them rather than crashing VS. We hook this up in the `ViewModelBase` static constructor don't want to force-load rx on package load.
jcansdale
approved these changes
Dec 11, 2018
Collaborator
There was a problem hiding this comment.
This works well. It doesn't crash and exceptions appear in the log. ✔️
We should really think about how to surface exceptions in a sensible way so that they have a chance of being reported. If this had been in place for the checks crash, chances are it wouldn't have been discovered/reported for a while.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, exceptions thrown in
ReactiveCommandexecute methods would crash the application. Add a handler toRxApp.DefaultExceptionHandlerto handle these exceptions and log them rather than crashing VS.We hook this up in the
ViewModelBasestatic constructor don't want to force-load rx on package load.