This repository was archived by the owner on Jun 21, 2023. It is now read-only.
Convert all projects to target .NET Framework 4.6 #2071
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the version that Visual Studio is compatible with. Compiling for .NET Framework 4.6.1 risks referencing assemblies that aren't always available.
grokys
approved these changes
Nov 20, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TLDR when building a desktop component for Visual Studio you must target net46 and no higher
What this PR does
TargetFrameworkofnet46supportedRuntimeforMetricsServer/App.configtov4.6.1(for consistency)What isn't fixed
There are still references to
net461in somepackages.configfiles, but these are going away anyway in a separate PR so I haven't touched them. For example:VisualStudio/src/GitHub.VisualStudio/packages.config
Line 4 in 26874eb
Related
System.ValueTuple.NET Standard issues on .NET Framework 4.7.1 dotnet/standard#567 (comment)Fixes #1849