Reference System.ValueTuple, Version=4.0.1.0

[jcansdale]

This is an attempted fix for #2065 and #2062.

Revert to using the System.ValueTuple, v4.3.0 NuGet package / assembly System.ValueTuple, Version=4.0.1.0.

What this PR does

• Change to reference the System.ValueTuple, 4.3.0 NuGet package (down from 4.5.0)
• Change to build for .NET Framework 4.6 (down from 4.6.1)

Issue #2062 sounds very much like this:
https://stackoverflow.com/a/50636962/121348

just had this issue myself. Not on Localhost while developing, but only on production server. In the end it turned out to be some sort of conflict between .Net Framework 4.6.1 and me having System.ValueTuple installed from Nuget in version 4.5.0.

The solution turned out to be, to downgrade the System.ValueTuple Nuget package to 4.3.0. Then it worked, like nothing had ever been an issue.

I suspect that this only happened on production server, cause of a different version of .net framework installed.

@chongchin and @declared-lambda, could you confirm whether not the issue you were experiencing is fixed in this build: GitHub.VisualStudio.zip

Update: I've hit a blocker on this one. It looks like ReactiveUI uses System.ValueTuple, v4.5.0. I think we'll need to package System.ValueTuple, v4.5.0 with the extension. I'll get a new build ready ASAP

Fixes #2062
Fixes #2065

[ghost]

It's not fixed. I uninstalled and installed the new extension. On the plus side, Visual Studio doesn't crash, however nothing actually happens in the screen besides this:

I have included the errors along with activitylog here:

https://gist.github.com/declared-lambda/50ee1e7160d29f54c95e4fb2a16fb086

[jcansdale]

@declared-lambda, thanks for trying that version, I'm sorry it didn't work!

Could you try my my next attempted fix:
https://ci.appveyor.com/api/buildjobs/blbeldj1d4lkkofe/artifacts/2.6.0.5790%2FGitHub.VisualStudio.vsix

This version is from #2068.

Thanks!

[jcansdale]

This didn't work. 😢 Trying #2068 instead.