This repository was archived by the owner on Jun 21, 2023. It is now read-only.
Remove repository responsibilities from TeamExplorerServiceHolder (repository refactor part 2) #2025
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
TeamExplorerServiceHolderhas picked up responsibilities beyond holding services for the Team Explorer views. This PR removes its repository watching and event marshaling responsibilities and delegates them toITeamExplorerContext. It also removes the need for refreshing a liveLocalRepositoryModel, meaning the model can now be immutable after creation.ActiveRepo,SubscribeandUnsubscribefromITeamExplorerServiceHolderRefreshCloneUrlfromIGitServiceTeamExplorerContextandJoinableTaskFactoryfromITeamExplorerServiceHolder(for repo change events and marshaling)How to test
I've changed code that listens for repository change and refreshes the Team Explorer UI. We need to test moving between repositories and changing the clone URL.
Team Explorer - Homeviewgit remote rename _origin origingit remote rename origin _origin