Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Conversation

@jcansdale
Copy link
Collaborator

@jcansdale jcansdale commented Oct 8, 2018

Note: This is made obsolete by #1982

We need to make sure Team Explorer - Home is visible before the clone operation starts so the user can see progress have the option to cancel.

What this PR does

  • Show Team Explorer - Home before clone starts rather than after it finishes

Make sure this UI is visible when cloning:

image

How to test

  1. Open the Clone dialog
  2. Start cloning a repository (e.g. https://github.com/dotnet/roslyn)
  3. Check Team Explorer - Home / Clone Repository is visible

Fixes #1977

We need to make sure Team Explorer - Home is visible before the clone
operation starts so the user can see progress have the option to cancel.
@codecov
Copy link

codecov bot commented Oct 8, 2018

Codecov Report

Merging #1978 into master will decrease coverage by 1.5%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1978      +/-   ##
==========================================
- Coverage   42.36%   40.85%   -1.51%     
==========================================
  Files         370      402      +32     
  Lines       15882    17100    +1218     
  Branches     2190     2370     +180     
==========================================
+ Hits         6728     6986     +258     
- Misses       8620     9564     +944     
- Partials      534      550      +16
Impacted Files Coverage Δ
src/GitHub.App/Services/RepositoryCloneService.cs 49.48% <100%> (ø) ⬆️
...nlineReviews/Services/PullRequestSessionManager.cs 82.05% <0%> (-1.03%) ⬇️
...c/GitHub.InlineReviews/Tags/InlineCommentTagger.cs 79.64% <0%> (-0.89%) ⬇️
...nlineReviews/Services/PullRequestSessionService.cs 16.7% <0%> (-0.41%) ⬇️
...rc/GitHub.VisualStudio/Commands/OpenLinkCommand.cs 0% <0%> (ø)
...Hub.VisualStudio/Commands/ShowGitHubPaneCommand.cs 0% <0%> (ø)
...o/Commands/GoToSolutionOrPullRequestFileCommand.cs 0% <0%> (ø)
src/GitHub.VisualStudio/Services/UsageTracker.cs 92.53% <0%> (ø)
.../GitHub.VisualStudio/Services/ShowDialogService.cs 0% <0%> (ø)
...Hub.VisualStudio/Commands/ShowMessageBoxCommand.cs 0% <0%> (ø)
... and 27 more

@jcansdale
Copy link
Collaborator Author

This is made obsolete by #1982.

@jcansdale jcansdale closed this Oct 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants