This repository was archived by the owner on Jun 21, 2023. It is now read-only.
Feature: Gist support #194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
November 24, 2015 22:58
…s being abstracted out.
…od instead of a bunch of params.
…eation on the web with dedicated public/private create buttons.
Bump version to 1.0.15.6
If we want to get really fancy, we could prob get what the extension of the file is we are creating the gist from and set that as the default. I need to check the VS API to see what we can get.
Previously, if an exception occurred while logging in to an account that has previously been logged in, then an AccountCacheItem was read from the cache and that was used. This meant we couldn't check the response's scopes for gist support.
This way we only need to make 1 request at login.
Now unit tests pass!
Always open gist on successful creation.
So we can use it with other features, if needed
Polish sign out required dialog
Read scopes at the same time as User.
Finished off gist support
Contributor
Contributor
Author
|
Yes this totally deserves a ton of gifs! @georgebearden Thank you SO MUCH for taking this on, and I'm so sorry it took so long to land this! I'll be putting up an alpha build of what is going to be 2.0 (or 1.1, haven't decided yet) in the releases page which includes the gist support.
|
Contributor
Author
|
Note: Issue is #39 |
Contributor
Author
|
It would have been small if it wasn't for that silly little token scope detail... that made it really bad! 😞 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulling in #156 to a staging branch
This needs:
This adds support for creating gists from selected text. It pops up a dialog to add filename and description to the gist (see #156 (comment))
Right now, popping up a dialog is easier because it integrates straight into our authentication flow, but I'm wondering if in the long term we want this on a side pane instead of a dialog, so it doesn't obscure the text and integrates more naturally with VS. Thoughts?