This repository was archived by the owner on Jun 21, 2023. It is now read-only.
Hide difference viewer sides when empty #1643
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When diff LeftView is empty, automatically set to show RightViewOnly. When diff RightView is empty, automatically set to show LeftViewOnly. Fixes #1624
grokys
approved these changes
May 3, 2018
Contributor
grokys
left a comment
grokys
left a comment
There was a problem hiding this comment.
This LGTM, and is a welcome change.
I was worried that setting the LHS/RHS-only setting would persist to diff views opened by e.g. Team Explorer Changes but that doesn't seem to be the case
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Previously when a file was added or deleted, the PR file diff view would show an empty view on the left or right side (depending on whether it was added or deleted).
This PR makes the diff view automatically hide the empty side.
This frees up a lot more space when adding or reviewing comments.
When a side it hidden in this way, the diff mode option will be ignored for this view (it's a global option and will be honored for views where there is something to diff).
Fixes #1624