This repository was archived by the owner on Jun 21, 2023. It is now read-only.
Notify PullRequestSessionManager when branch changes #1409
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to be notified when a branch changes. ITeamExplorerServiceHolder only fires when moving to a new repo. IVSGitExt.ActiveRepositoriesChanged also fires when a branch changes.
TeamExplorerContext uses IVSGitExt and ITeamExplorerServiceHolder to expose all status change events.
Delegate `ActiveRepository` property to `ITeamExplorerServiceHolder.ActiveRepo`.
Collaborator
Author
|
Came across this one while testing:
|
TeamExplorerContext is now a simple wrapper on top TeamExplorerServiceHolder that exposes events.
Collaborator
Author
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PullRequestSessionManagerneeds to be notified when a branch changes.ITeamExplorerServiceHolderonly fires when moving to a new repo.IVSGitExt.ActiveRepositoriesChangedalso fires when a branch changes.I've changed
PullRequestSessionManagerto use a newITeamExplorerContextservice rather thanITeamExplorerServiceHolder.TeamExplorerContextsimple facade on top ofIVSGitExtandITeamExplorerServiceHolder.It notifies of any change to the active repository using the
StatusChangedevent and exposes an up to dateILocalRepositoryModelviaGetActiveRepository.Ultimately it would be nice if
ActiveRepositorywas a property and theLocalRepositoryModelwas updated rather than recreated when its status changes.This PR is simply intended to unblock #1396. I'm reluctant to attempt any more radical refactoring without @shana's input.
Fixes #1408