This repository was archived by the owner on Jun 21, 2023. It is now read-only.
Fix calculating machine fingerprint. #1390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Start from the fastest NIC (`OrderByDescending` instead of `OrderBy`) and check for length of `>= 12` instead of `> 12`. This results in a better machine identifier on my machine at least.
Even if it means including it twice ;)
Contributor
|
This is working great @grokys 🎉 i can now use VS2015 and VS2017 side-by-side |
meaghanlewis
approved these changes
Dec 14, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our logic for calculating the machine identifier for the OAuth fingerprint was flaky, meaning that the same fingerprint was easily created on different machines. Try fixing it by:
OrderByDescendinginstead ofOrderBy) and check for length of>= 12instead of> 12. This results in a better machine identifier on my machine at least.MachineFingerprint.FIxes #1234