Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

MVVM-ize things (attempt 2) #1367

Merged
merged 29 commits into from
Dec 5, 2017
Merged

MVVM-ize things (attempt 2) #1367

merged 29 commits into from
Dec 5, 2017

Conversation

@grokys
Copy link
Contributor

@grokys grokys commented Dec 5, 2017

#1346 was targeting the wrong branch (it was targeting #1353) when I pushed. This PR is exactly the same as #1346 except targeting master.

grokys added 28 commits November 28, 2017 19:42
@grokys
Rebase of MVVM refactor.
5106ff5 
The MVVM refactor (#1346) was originally based on the SSO feature branch and had a _lot_ of WIP etc commits. Rebased it off of #1353 and squashed into a single commit.
@grokys
Added some doc comments.
c71b2ab
@grokys
Use IViewViewModelFactory...
1a886bf 
...instead of `IGitHubServiceProvider` to create view models in `GitHubDialogWindowViewModel`. Also added some doc comments.
@grokys
Add DialogService to MenuBase.
8c2f286
@grokys
Fix compile error.
c50b29a
@grokys
Removed unused types.
91703a4
@grokys
Added move developer docs.
d928d72
@grokys
Include VSGitExt in GitHub.TeamFoundation.15.
a3fe54b 
Fixes #1355.
@grokys
Merge branch 'fixes/1355-vsgitext-vs2017' into refactor/mvvm
c578ecd
@grokys
Added progress bar to Clone dialog page.
42c1d34
@grokys
Added general purpose ContentView.
16df7cc 
And use it instead of defining `LoginView` and `NavigationView` separately.
@grokys
Supress CA error.`
7273371 
MEF requires an array here.
@grokys
Doc comments.
e7c4ef0
@grokys
Don't add current page to current page.
22c8345 
When the page to be navigated to in the GitHub pane is the current page, do nothing.
@grokys
Display error messages in GitHubPane.
9ee5f0e
@grokys
Fix unit tests.
f8e48fb
@grokys
Fixed spinner showing when logged out.
304485e
@grokys
Fix DataContext/ViewModel property sync.
0dac942
@grokys
Fixed XAML errors in docs.
6f4fe80
@grokys
Show title in dialog window.
1c24639
@grokys
Doc fixes.
67a8a8c
@grokys
Added ShowDefaultPage to GitHubPaneViewModel.
c1c58c5
@grokys
Added docs for implementing a pane page.
5372cad
@grokys
Expose IGitHubPaneViewModel.NavigateTo(Uri).
b93c6f9
@grokys
Merge branch 'master' into refactor/mvvm
68fd076 
 Conflicts:
	src/GitHub.App/ViewModels/GitHubPane/PullRequestDetailViewModel.cs
@grokys
Fix broken tests.
2a85875
@grokys
Switch to UI thread in ActiveRepositoriesChanged.
2eb687c 
`IVSGitExt.ActiveRepositoriesChanged` isn't notified on the UI thread which breaks things. Switch to the main thread when refreshing due to a notification from this.
@grokys
Suppress CA error.
f771bb8
@grokys grokys requested review from drguthals and jcansdale December 5, 2017 17:44
jcansdale
jcansdale approved these changes Dec 5, 2017
View reviewed changes
Copy link
Collaborator

@jcansdale jcansdale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jcansdale jcansdale merged commit 2353ab1 into master Dec 5, 2017
@jcansdale jcansdale deleted the refactor/mvvm branch December 5, 2017 18:13
@grokys grokys mentioned this pull request Dec 12, 2017
Closed
grokys added a commit that referenced this pull request Dec 12, 2017
@grokys
Fix switching between fork and master PRs
38f9724 
#1367 accidentially removed the code to refresh the PR list when switching between fork and parent PRs. Also update the `WebUrl` when this happens to fix #1218.

Fixes #1380
Fixes #1218
@grokys grokys mentioned this pull request Dec 12, 2017
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@drguthals drguthals Awaiting requested review from drguthals

1 more reviewer

@jcansdale jcansdale jcansdale approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@grokys @jcansdale