ci: Add options to run VLAB/HLAB tests on manual dispatch #936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qmonnet
requested review from
Fredi-raspall,
Copilot,
daniel-noland and
mvachhar
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the manual dispatch interface for the dev.yml workflow by adding three boolean input options that allow users to enable VLAB tests, HLAB tests, and release tests when triggering the workflow manually. Previously, these test types could only be enabled through Pull Request labels, which are unavailable in manual workflow dispatches.
Key changes:
- Added three boolean workflow dispatch inputs:
run_vlab_tests,run_hlab_tests, andenable_release_tests - Updated the
skiplogic to check both the new inputs and existing PR labels using OR conditions - Modified the
releasetestparameter to consider the newrun_release_testsinput alongside the existing label check
qmonnet
force-pushed
the
pr/qmonnet/vlab-workflow-trigger
branch
from
65c816d to
638de30
Compare
When we manually trigger the dev.yml workflow to run tests, we don't have Pull Request labels in the context, and can't turn VLAB or HLAB tests on. Add options to enable these tests (and the "release" tests) via the dispatch interface. Signed-off-by: Quentin Monnet <[email protected]>
qmonnet
force-pushed
the
pr/qmonnet/vlab-workflow-trigger
branch
from
638de30 to
1b16d22
Compare
|
Fredi reported that VLAB tests are currently failing, this is not related to this PR. |
There was a problem hiding this comment.
Looks good to me @qmonnet , thanks!
We should document somewhere what options do we have wrt to ci pipelines/workflows etc. I see a lot of workflow files but have to admit that have very little idea of what they do.
This adds comprehensive documentation for all GitHub workflows in the repository, including triggers, main steps, and available options for manual dispatch and PR labels. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Prompt: Look at all GitHub workflow files under .github/workflows/, and produce a file .github/workflows/README.md that summarizes the different workflows, what they do, the main steps, and on what triggers. You may mention the main elements from the job matrix if any, but don't go super deep into the details. For the dev.yaml, mention the main "options" that users can use via labels (when running the workflow on a Pull Request) or via dispatch options. The objective is to help contributors not familiar with CI understand what workflows we have in this repository. Quentin: I did a second pass, changed the formatting, cleaned up and trimmed or completed some pieces of information. Suggested-by: Fredi Raspall <[email protected]> Co-Authored-By: Claude <[email protected]> Signed-off-by: Quentin Monnet <[email protected]>
qmonnet
force-pushed
the
pr/qmonnet/vlab-workflow-trigger
branch
from
dbbef94 to
becb0f8
Compare
|
@Fredi-raspall True. I added a commit with an overview of the workflows, please take a look. |
mvachhar
approved these changes
Oct 24, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we manually trigger the dev.yml workflow to run tests, we don't have Pull Request labels in the context, and can't turn VLAB or HLAB tests on. Add options to enable these tests (and the "release" tests) via the dispatch interface.