Plugin manager disappeared after update to 4.0.1

[mycroes]

Environment

• Git Extensions 4.0.1.15887
• Build f2567de
• Git 2.38.1.windows.1
• Microsoft Windows NT 10.0.19045.0
• .NET 6.0.12
• DPI 96dpi (no scaling)
• Microsoft.WindowsDesktop.App Versions

    Microsoft.WindowsDesktop.App 3.0.1 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
    Microsoft.WindowsDesktop.App 3.1.1 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
    Microsoft.WindowsDesktop.App 3.1.14 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
    Microsoft.WindowsDesktop.App 3.1.20 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
    Microsoft.WindowsDesktop.App 3.1.29 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
    Microsoft.WindowsDesktop.App 3.1.30 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
    Microsoft.WindowsDesktop.App 5.0.4 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
    Microsoft.WindowsDesktop.App 5.0.5 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
    Microsoft.WindowsDesktop.App 5.0.9 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
    Microsoft.WindowsDesktop.App 5.0.17 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
    Microsoft.WindowsDesktop.App 6.0.9 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
    Microsoft.WindowsDesktop.App 6.0.10 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
    Microsoft.WindowsDesktop.App 6.0.12 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]

Issue description

After update to 4.0.1 Plugin manager is no longer visible in Plugins menu. The Plugin manager is still present in AppData\Local\GitExtensions\UserPlugins. The Gerrit plugin that's in the same UserPlugins directory does still work.

Steps to reproduce

Update to GitExtensions 4.0.1

Did this work in previous version of GitExtensions?

Yes, 4.0.0.

Diagnostics

No response

[mstv]

Are we back in the DLL hell?
It works with the PluginManager shipped with v4.0.0.

[maraf]

Do we have a log from plugin loading? I tried the head of main yesterday with the same release of Plugin Manager and it was working.

[mstv]

What kind of log do you mean, @maraf?

[maraf]

Kind of why the plugin assembly wasn't loaded? Or whether it was at least considered?
Will it help to add some logging in here?

gitextensions/Plugins/GitUIPluginInterfaces/ManagedExtensibility.cs

Lines 93 to 103 in 9f5deca

	private static Assembly? TryLoadAssembly(FileInfo file)
	{
	try
	{
	return Assembly.LoadFile(file.FullName);
	}
	catch
	{
	return null;
	}
	}

[mstv]

If I replace the GitExtensions.PluginManager.dll with an older version, it is loaded. So it is considered.
I cannot reproduce it with my locally built portable version of v4.0.1. I am out.
Where does the portable version search for the user plugins? Where in the code, does it switch from not searching in %APPDATA%?

BTW: Why TryLoadAssembly without any error logging. This ends in such debug sessions! I hate error-hiding.

[mycroes]

My GitExtensions.PluginManager.dll has version 2.0.0.184. I checked out GitExtensions, ran from VS, PluginManager is there. Initially I did this from release/4.0 branch, so I thought maybe there was something in the commits after 4.0.1 handling it, but I resetted to v4.0.1 tag and it still shows up... Not sure how I can debug installed GitExtensions; it doesn't enable breakpoints because no debugging symbols are loaded.

If there's anything I can check let me know, otherwise I'll see what I can figure out on my own.

[RussKie]

GitExtensions.PluginManager.dll has version 2.0.0.184.

That's the correct version.

…

On Fri, 16 Dec 2022 at 10:06, Michael Croes ***@***.***> wrote: My GitExtensions.PluginManager.dll has version 2.0.0.184. I checked out GitExtensions, ran from VS, PluginManager is there. Initially I did this from release/4.0 branch, so I thought maybe there was something in the commits after 4.0.1 handling it, but I resetted to v4.0.1 tag and it still shows up... Not sure how I can debug installed GitExtensions; it doesn't enable breakpoints because no debugging symbols are loaded. If there's anything I can check let me know, otherwise I'll see what I can figure out on my own. — Reply to this email directly, view it on GitHub <#10529 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABBTEXSOD7SJFVTG4SHYWV3WNOP7XANCNFSM6AAAAAAS7WVXHA> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[RussKie]

Is there anything related in the error log (#9227)?

[mycroes]

Is there anything related in the error log (#9227)?

No error log is created, but I also don't get any exceptions. It's just not there in the menu, while the Gerrit plugin is actually functioning (to some extent, but that's almost solved now). I'll have another go at it, will report back.

[mycroes]

Next attempt: I replaced GitUIPluginInterfaces.dll (in GitExtensions install location) with the one built locally, added the pdb. Had to also copy GitExtUtils.dll because different version was now referenced. Now I can debug from VS, which gives me the following:

As you can see in the watch window it does find the GitExtensions.PluginManager.dll the catch in TryLoadAssembly is never hit, however the catalog doesn't seem to include the PluginManager. I never used any of the Microsoft.VisualStudio.Composition stuff and I'd rather not waste my time on diving into it's internals, but I don't mind testing anything in the context of the ManagedExtensibility class.

Side question, would it be possible to create a debug build (including symbols) of GE on release that would permit attaching without overwriting any of the GE files? Would make it easier to debug issues like these.