Skip to content

Conversation

@gerhardol
Copy link
Member

add files added in the release/3.0 branch, required since GE4.0
Prepare for signing releases.

Also including the signing of the artifacts, for release/ branches

add files added in the release/3.0 branch, required since GE4.0
Prepare for signing releases.
@gerhardol gerhardol requested review from RussKie, maraf and mstv September 20, 2025 19:33
Copy link
Member

@mstv mstv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The .zip contains PackageManager.UI.runtimeconfig.json now. 👍

But there is a confusing message "Build was forcibly terminated" in the CI build log:

[INFO]: Do not sign artifacts from PR to release branch
Uploading artifact GitExtensions.PluginManager.3.1.1.260.nupkg (5,342,838 bytes)...100%
Uploading artifact GitExtensions.PluginManager.3.1.1.260.zip (5,340,153 bytes)...100%
Build was forcibly terminated
Build success

@gerhardol
Copy link
Member Author

But there is a confusing message "Build was forcibly terminated" in the CI build log:

This is intentional, I tool this from the release branch - want to avoid special changes in release/

Copy link
Member

@mstv mstv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

without deep knowledge

@gerhardol gerhardol merged commit 0715532 into master Sep 21, 2025
3 checks passed
@gerhardol gerhardol deleted the feature/missing-files branch September 21, 2025 13:27
@gerhardol
Copy link
Member Author

Initiated a signing, but called the branch release/3.1.0. The signed artifact should be used in a GH release

@mstv
Copy link
Member

mstv commented Sep 21, 2025

PackageManager.UI.exe needs the 32-bit .NET 9.0.9 runtime.
GitExtensions.PluginManager.dll needs the 32-bit .NET 8.0.20 runtime.
Do you want to change this yet?

Where should the plugin manager appear in GE?
I could not find it running https://ci.appveyor.com/api/buildjobs/rgmr9h3dtvi1bt8a/artifacts/combined.6.0.2.18242-unsigned.zip

v6.0.2:
image

Was better in v6.0.1:
image

@gerhardol
Copy link
Member Author

GitExtensions.PluginManager.dll is built together with PackageManager.UI.exe and should use the same environment as GE. But 32-bit?
PM is installed in C:\Users<user>\AppData\Local\GitExtensions\UserPlugins\GitExtensions.PluginManager when running the 6.0.2 installer.
PM do not appear with the 6.0.2 build but with the .net10 I use

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants