Skip to content

Conversation

@mast-eu
Copy link
Member

@mast-eu mast-eu commented Oct 24, 2019

In PR #36 I've overseen that 2 different targets in GitExtensions.PluginManager.csproj were copying the file PackageManager.UI.exe to different locations:

  1. $(TargetDir)\PackageManager\PackageManager.UI.exe for building the NuGet package
  2. $(GitExtensionsPluginsPath)\$(ProjectName)\PackageManager\PackageManager.UI.exe for local testing and debugging.

As a result, the second copy was erroneously removed.

The original targets (previous to #36) were:

<Target Name="CopyPackageManager" AfterTargets="ResolveReferences">
<Copy SourceFiles="$(PackageManagerSourcePath)" DestinationFolder="$(TargetDir)PackageManager" />
</Target>
<Target Name="PostBuild" AfterTargets="PostBuildEvent">
<Copy SourceFiles="$(TargetDir)$(PackageManagerTargetPath)" DestinationFolder="$(GitExtensionsDebugPluginsPath)PackageManager" />
<Copy SourceFiles="$(TargetPath)" DestinationFolder="$(GitExtensionsDebugPluginsPath)" />
</Target>

This PR now restores the second copy, in order to use the correct PackageManager.UI.exe locally for debugging and testing.

@mast-eu mast-eu added this to the 1.1.0 milestone Oct 24, 2019
@mast-eu mast-eu requested a review from maraf October 24, 2019 22:14
@mast-eu mast-eu self-assigned this Oct 24, 2019
@mast-eu mast-eu merged commit fd4cce0 into gitextensions:master Oct 25, 2019
@mast-eu mast-eu deleted the RegressionPr36 branch October 25, 2019 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants