Search by tags #30

maraf · 2019-08-27T18:15:58Z

Resolves #27.

All searching is now in form of id: {searchTerm} tags:GitExtensions. This pre-filters packages marked as GitExtensions, than it loads a dependency graph (one query per package) and checks if dependency on GitExtensions.Extensibility exists.

Searching using nuget.org search syntax (https://docs.microsoft.com/en-us/nuget/consume-packages/finding-and-choosing-packages#search-syntax) is not ideal.

When search term is "g", it won't find "GitExtensions.SVN"; the user must type "git", or "extensions".
This behavior can be even seen on the web:

https://www.nuget.org/packages?q=id%3Agitextension (0 packages)
https://www.nuget.org/packages?q=id%3Agitextensions (6 packages)

It seems it doesn't work well on MyGet.

In blog post from 2013 they said it should work, but from my observation it just ignores the "id part".
Using "id:{searchTerm}" requires to match whole packageId, nothing like "starts with" or "contains".

It doesn't work at all when source is a folder on disk.

Using "id:{searchTerm}" requires to match whole packageId, nothing like "starts with" or "contains".
Tags searching doesn't work.

Solution

On all feeds except local folder, load packages with tags filter, then apply id filter on loaded packages.
On local folder feed, load all packages from feed, then apply tags and id filters on loaded packages.
All local (in-app) filters are applied as invariant-culture ignore-case.

mast-eu · 2019-08-28T07:33:38Z

Few questions / comments:

How did you solve NuGet package is "Not compatible" #27? E.g. do you append tags: GitExtensions to all search terms? Do you first filter for tags and afterwards for dependency on GitExtensions.Extensibility?
When search term is "g", it won't find "GitExtensions.SVN"; the user must type "git", or "extensions".

MS is testing a new search on nuget.org these days. Might be the reason for some strange results. https://devblogs.microsoft.com/nuget/new-and-improved-nuget-search/

It doesn't work at all when source is a folder on disk.

What is the use case for this? Do you use it for debugging or is the PM internally doing this at some point?

It seems it doesn't work well on MyGet.

Any idea why? If not, I'm inclined to take this behaviour as a normal bug - if it affects only not preconfigured feeds (i.e. any feed except nuget.org).

A solution for the NuGet package is "Not compatible" #27.

Please write Closes #27 or Resolves #27. This way the issue will be automatically closed when the PR is merged. More info: https://help.github.com/en/articles/closing-issues-using-keywords#about-issue-references

Is this PR a draft because you're still working on it?

maraf · 2019-08-28T08:50:43Z

Sorry for being so brief in PR description...

All searching is now in form of id: {searchTerm} tags:GitExtensions. This pre-filters packages marked as GitExtensions, than it loads a dependency graph (one query per package) and checks if dependency on GitExtensions.Extensibility exists.
Not sure, it seems like they split package id by pascal-case and dots and that it needs to match whole word (just observation).
A folder on disk is a valid NuGet feed. I'm using it during debugging.
Today I'm going to investigate, don't have any clues yet.
Ook.
It's a draft because it only works on nuget.org, today I'm going to give it a bit more time.

mast-eu · 2019-08-28T16:35:49Z

it seems like they split package id by pascal-case and dots and that it needs to match whole word (just observation).

I made the same observation. Searching for GitExtensions.SVN or id:GitExtensions.SVN or id:"GitExtensions.SVN" always gives results similar to Git OR Extensions OR SVN. Resulting in >10000 hits, although there is a package with the very same ID. Pretty useless for our case.
Anyhow, searching for id:{searchTerm} tags:GitExtensions seems to entirely avoid the flood of not matching packages 👍

maraf · 2019-08-28T16:44:54Z

@mast-eu Last thing I'm considering is skipping id search on feeds and filter packages in PM. It's quite dirty, but until we have hundreds of plugins, it will work. Thoughts?

mast-eu · 2019-08-28T19:19:22Z

Getting all packages with tags:GitExtensions from all configured feeds directly on startup? IMHO that's ok.

RussKie · 2019-08-28T21:10:45Z

👍

…

On Wed, Aug 28, 2019, 10:19 PM Martin Steinisch ***@***.***> wrote: Getting all packages with tags:GitExtensions from all configured feeds directly on startup? IMHO that's ok. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#30?email_source=notifications&email_token=ABBTEXQQEGHSYXF5RHMDOW3QG3FTVA5CNFSM4IQIHBUKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5MF77A#issuecomment-525885436>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABBTEXUWX2LHVMTZU4GIGFTQG3FTVANCNFSM4IQIHBUA> .

maraf · 2019-08-29T17:45:58Z

I still need to fix two tests...

…ll filters in app.

- Split one big method into multiple smaller. - Simplify conditions for continuing search on next page. - Fix loading single package (method FindLatestVersionAsync) when local filtering applies.

maraf · 2019-08-29T19:30:05Z

I have removed NuGet.Client update, because the never version doesn't support reordering of feeds, which we currently use. We can do the update later...

src/PackageManager.NuGet/Services/EmptyNuGetSearchTermTransformer.cs

src/PackageManager.NuGet/Services/INuGetPackageFilter.cs

src/PackageManager.NuGet/Services/NuGetPackageVersionService.cs

RussKie · 2019-08-30T11:47:47Z

src/PackageManager.NuGet/Services/NuGetSearchTerm.cs

+        public List<string> Tags { get; } = new List<string>();
+        public List<string> Description { get; } = new List<string>();
+        public List<string> Summary { get; } = new List<string>();
+        public List<string> Owner { get; } = new List<string>();


All of these can be mutated outside the class and may lead to unexpected situations. Is this really required?

I'm sorry, but I don't get the point. There are supported filter parameters. As searching supports multiplicity for earch parameter, they are all defined as lists. The class is designed as mutable, as implementations of INuGetPackageFilter may add or remove values.

@maraf is right. In the current design these are all supposed to be public.

src/PackageManager.UI/Args.cs

src/PackageManager/ViewModels/PackageSourceSelectorViewModel.cs

RussKie · 2019-08-30T13:57:28Z

FilterAsync?

…

On Fri, Aug 30, 2019, 4:54 PM Marek Fišera ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In src/PackageManager.NuGet/Services/INuGetPackageFilter.cs <#30 (comment)> : > using System.Threading.Tasks; namespace PackageManager.Services { public interface INuGetPackageFilter { - NuGetPackageFilterResult IsPassed(IPackageSearchMetadata package); + Task<NuGetPackageFilterResult> IsPassedAsync(SourceRepository repository, IPackageSearchMetadata package, CancellationToken cancellationToken); Any suggestions? Does GetFilterResultAsync sounds better? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#30?email_source=notifications&email_token=ABBTEXW2ZRJC7G25RIYATH3QHERBJA5CNFSM4IQIHBUKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCDH3BYQ#discussion_r319522819>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABBTEXR4AEXRQ2PLD7JEOJLQHERBJANCNFSM4IQIHBUA> .

- All package id and version are compared case-insensitive. - Instead of String use string. - Rename method of INuGetPackageFilter.

mast-eu

I made a lot of functional testing with this PR and everything is working as expected.

mast-eu · 2019-09-03T07:14:15Z

Thank you

maraf self-assigned this Aug 27, 2019

mast-eu added this to the 1.0.0 milestone Aug 27, 2019

mast-eu self-requested a review August 27, 2019 22:01

maraf added 5 commits August 29, 2019 21:26

Filter packages by tags.

5e516ef

Dependency filtering using DependencyInfoResource.

9062483

Delaying id search after packages are loaded from feed.

916efd5

When feed is a local folder, search for all packages and than apply a…

16be307

…ll filters in app.

Refactoring of inner workings of NuGetSearchService.

6696507

- Split one big method into multiple smaller. - Simplify conditions for continuing search on next page. - Fix loading single package (method FindLatestVersionAsync) when local filtering applies.

maraf force-pushed the SearchByTags branch from 7f3f3f0 to 6696507 Compare August 29, 2019 19:28

maraf marked this pull request as ready for review August 29, 2019 19:30

maraf requested a review from RussKie August 29, 2019 19:30

RussKie reviewed Aug 30, 2019

View reviewed changes

Changes based on code-review.

621020b

- All package id and version are compared case-insensitive. - Instead of String use string. - Rename method of INuGetPackageFilter.

mast-eu approved these changes Aug 30, 2019

View reviewed changes

mast-eu merged commit 91c5b32 into gitextensions:master Sep 3, 2019

maraf deleted the SearchByTags branch September 3, 2019 08:14

Uh oh!

Search by tags #30

Search by tags #30

Uh oh!

Conversation

maraf commented Aug 27, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Solution

Uh oh!

mast-eu commented Aug 28, 2019

Uh oh!

maraf commented Aug 28, 2019

Uh oh!

mast-eu commented Aug 28, 2019

Uh oh!

maraf commented Aug 28, 2019

Uh oh!

mast-eu commented Aug 28, 2019

Uh oh!

RussKie commented Aug 28, 2019 via email

Uh oh!

maraf commented Aug 29, 2019

Uh oh!

maraf commented Aug 29, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

RussKie Aug 30, 2019

Choose a reason for hiding this comment

Uh oh!

maraf Aug 30, 2019

Choose a reason for hiding this comment

Uh oh!

mast-eu Sep 2, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

RussKie commented Aug 30, 2019 via email

Uh oh!

mast-eu left a comment

Choose a reason for hiding this comment

Uh oh!

mast-eu commented Sep 3, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

maraf commented Aug 27, 2019 •

edited

Loading