PluginManager remains open when GE is closed

[mast-eu]

Steps to reproduce

1. open PM
2. close GE

What happens?

PM window remains open.

What should happen?

PM window gets automatically closed.

@maraf : is this needed for updates or should this be considered as an undesired behavior?

[maraf]

@mast-eu As GE locks plugin dlls (at least few versions back, not sure for MEF), PM must close all instances of GE before executing update. And so must remain opened after GE is closed.

Maybe we can make PM a modal window over GE.

[mast-eu]

As GE locks plugin dlls (at least few versions back, not sure for MEF), PM must close all instances of GE before executing update.

Ok, i see. I didn't check explicitly, but I don't think anything has changed with how DLLs are handled.

I was thinking of adding to plugin.cs something like:

// Called when GE closes or repo is changed
public override void Unregister(IGitUICommands commands)
        {
            if(no_updates_pending)
                   ClosePluginManager();
        }

This should be feasible, right?

[RussKie]

Are there any objections to make the PM modal like all other plugins?

…

On Wed, May 29, 2019, 5:29 PM Martin Steinisch ***@***.***> wrote: As GE locks plugin dlls (at least few versions back, not sure for MEF), PM must close all instances of GE before executing update. Ok, i see. I didn't check explicitly, but I don't think anything has changed with how DLLs are handled. I was thinking of adding to plugin.cs something like: // Called when GE closes or repo is changed public override void Unregister(IGitUICommands commands) { if(no_updates_pending) ClosePluginManager(); } This should be feasible, right? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#5?email_source=notifications&email_token=ABBTEXWGDGIDSV6RI36XP63PXYWDZA5CNFSM4HQHRKGKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWONZCA#issuecomment-496819336>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABBTEXQKCDPKKZEBMKGWLVTPXYWDZANCNFSM4HQHRKGA> .

[maraf]

Are there any objections to make the PM modal like all other plugins?

I don't see any problems with modal PM, rather the opposite.

[maraf]

I was thinking of adding to plugin.cs something like:

// Called when GE closes or repo is changed
public override void Unregister(IGitUICommands commands)
        {
            if(no_updates_pending)
                   ClosePluginManager();
        }

This should be feasible, right?

This may be bit tricky. PM is not the same process as GE-plugin. To realize this, they would need to communicate in some way..

[mast-eu]

I like the idea of making the PM modal. In this case my suggestion and #4 will be both obsolete.

[maraf]

I'm going to close this one in favor of #13, but feel free to reopen it.