Skip to content

Conversation

@gerhardol
Copy link
Member

Is this needed for plugins?

@gerhardol gerhardol requested a review from RussKie August 16, 2025 21:23
@gerhardol gerhardol changed the title feat: 0.4.0 fir GitExtensions 6.0 feat: 0.4.0 for GitExtensions 6.0 Aug 16, 2025
@RussKie
Copy link
Member

RussKie commented Aug 17, 2025

I don't know, tbh. It doesn't look like there are any coupling to a specific version of GE.
So, probably, not neeeded?

@gerhardol gerhardol changed the title feat: 0.4.0 for GitExtensions 6.0 feat: 0.3.3 for GitExtensions 6.0 Aug 17, 2025
@gerhardol
Copy link
Member Author

I now realizes what this does, it packages GitExtensions.Extensibility from master.
This was not done at all for the 5.x releases, even if there were some bigger changes from 4.2.1 -5.x
Much fewer changes from 5.2.1 to 6.0.0, but I get a Gerrit popup due to to changed interfaces.

Some plugins uses [0.3-0.4)
I would say this a bugfix release

Maybe including the following too?
gitextensions/gitextensions#12469

@RussKie
Copy link
Member

RussKie commented Aug 19, 2025

Sounds good

@maraf
Copy link
Member

maraf commented Aug 19, 2025

I don't know, tbh. It doesn't look like there are any coupling to a specific version of GE.

The coupling is in https://github.com/gitextensions/gitextensions.pluginmanager/blob/master/src/GitExtensions.PluginManager/Plugin.cs#L55.

The idea is that by selecting minimal version, we limit plugins targeting the version. In other words, ideally we should SemVer (or to simplify things follow Git Extensions version) this package to be able to filter-out plugin targeting older, possibly incompatible, version of Git Extensions

@maraf
Copy link
Member

maraf commented Aug 19, 2025

If 6.0 is next major release, we should bump this package to 0.4.0 and update the version in Plugin.cs to 0.4.0 as well, to follow the pattern from previous releases.

@gerhardol
Copy link
Member Author

If 6.0 is next major release, we should bump this package to 0.4.0 and update the version in Plugin.cs to 0.4.0 as well, to follow the pattern from previous releases.

There were no update at all for GE5 and there are quite few changes in GE6. So apps that use 0.3 often works. At least Gerrit plugin will require a recompile with new version.
But from a strict SemVer perspective, the minor version need to be updated too.

@gerhardol
Copy link
Member Author

The PRs in milestone for 6.0.0 is now merged, this should be merged so plugins can be prepared

@maraf
Copy link
Member

maraf commented Aug 20, 2025

If Git Extensions V6 are "backward compatible" with existing plugins, we don't need to bump anything.

@gerhardol
Copy link
Member Author

If Git Extensions V6 are "backward compatible" with existing plugins, we don't need to bump anything.

GE 5 did more changes, but the ext version was not changed. No reported problems.
GE 6 makes less changes, but at least one change requires changes in the Gerrit plugin so a new version is required.

It depends on the plugins how the change hits them. I would assume most are compatible with GE4/GE5. If ext version is changed they could stop working.

But we could set version to 0.4 and require plugin updates.

@maraf
Copy link
Member

maraf commented Aug 20, 2025

I agree with 0.4

@gerhardol gerhardol changed the title feat: 0.3.3 for GitExtensions 6.0 feat: 0.4.0 for GitExtensions 6.0 Aug 20, 2025
@RussKie
Copy link
Member

RussKie commented Aug 22, 2025

I don't know, tbh. It doesn't look like there are any coupling to a specific version of GE.

The coupling is in https://github.com/gitextensions/gitextensions.pluginmanager/blob/master/src/GitExtensions.PluginManager/Plugin.cs#L55.

The idea is that by selecting minimal version, we limit plugins targeting the version. In other words, ideally we should SemVer (or to simplify things follow Git Extensions version) this package to be able to filter-out plugin targeting older, possibly incompatible, version of Git Extensions

It would be great to add this to the readme or somewhere else where we'd find it :)

@gerhardol gerhardol merged commit e2df8f9 into master Aug 23, 2025
3 checks passed
@gerhardol gerhardol deleted the feature/ge6 branch August 23, 2025 21:14
@gerhardol
Copy link
Member Author

@RussKie @maraf
Publish fails, so pluginmanager/gerritplugin fails
https://ci.appveyor.com/project/gitextensions/gitextensions-extensibility/builds/52620221

Publishing GitExtensions.Extensibility.0.4.0.107.nupkg to https://www.nuget.org/api/v2/package...
Error publishing package. NuGet server returned 403: The specified API key is invalid, has expired, or does not have permission to access the specified package.

What account is used?
Can you update the API key?
(It should not be published in Git though...)

@maraf
Copy link
Member

maraf commented Aug 24, 2025

IIRC we are deploying every change

@gerhardol
Copy link
Member Author

IIRC we are deploying every change

There is a master branch check
And api key has expired

@gerhardol
Copy link
Member Author

The check is here
https://github.com/gitextensions/gitextensions.extensibility/blob/master/appveyor.yml#L37

MSVS should probably be 2022 too

@maraf
Copy link
Member

maraf commented Aug 25, 2025

It would be great to add this to the readme or somewhere else where we'd find it :)

gitextensions/gitextensions.pluginmanager#81

Can you update the API key?

I'm not using AppVeyor actively in recent years. The only account I was able to find, doesn't have Git Extensions access. @RussKie could you please generate a new API key and apply it to AppVeyor?

@maraf
Copy link
Member

maraf commented Aug 26, 2025

Package is now being published https://www.nuget.org/packages/GitExtensions.Extensibility/0.4.0.111

@RussKie
Copy link
Member

RussKie commented Aug 26, 2025 via email

@gerhardol
Copy link
Member Author

Apologies, I was meant to update the keys months ago, but the RL kept me
busy.

Looks like it's sorted now. Please let me know if you still need my help.

A package is published but it is not used. See related plugin Manager and gettot prs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants