FuzzerTrue-01948820-7004-7062-a14f-a20e061ceb52

[optimus-primal]

Gig seed=16050863125408122264 prob=0.99
Ran track: This automated PR permanently enables the GITAR_PLACEHOLDER feature flag.

Summary of Changes

Gitar found and removed uses of the GITAR_PLACEHOLDER feature flag across 11 files. Some of these files include:

• plog-client/src/main/java/com/airbnb/plog/client/MultipartMessage.java
• plog-kafka/src/test/java/com/airbnb/plog/kafka/partitioner/FlinkPartitionerTest.java
• plog-server/src/main/java/com/airbnb/plog/server/commands/FourLetterCommandHandler.java
• plog-server/src/main/java/com/airbnb/plog/server/packetloss/PortHoleDetector.java
• plog-server/src/test/groovy/com/airbnb/plog/handlers/ReverseBytesProvider.java

Gitar performed deep cleanup and code optimizations triggered by the feature flag removal in 9 of these files.

Code Cleanup Details

• plog-client/src/main/java/com/airbnb/plog/client/MultipartMessage.java

  • Replaced Feature Flag Usage (3 times)

• plog-client/src/main/java/com/airbnb/plog/client/PlogClient.java

  • Replaced Feature Flag Usage (4 times)
  • Cleaned up code (4 times)
    • Simplified control flow (3 times)
    • Simplified boolean expressions

• plog-kafka/src/main/java/com/airbnb/plog/kafka/KafkaProvider.java

  • Replaced Feature Flag Usage (4 times)
  • Cleaned up code (7 times)
    • Deleted the unused variable clientId
    • Deleted the unused variable defaultTopic
    • Deleted the unused variable encryption
    • Propagated the value true to uses of the variable clientId (2 times)
    • Propagated the value true to uses of the variable defaultTopic
    • Simplified control flow

• plog-kafka/src/test/java/com/airbnb/plog/kafka/partitioner/FlinkPartitionerTest.java

  • Replaced Feature Flag Usage
  • Cleaned up code (3 times)
    • Deleted the unused variable encoded
    • Propagated the value true to uses of the variable encoded (2 times)

• plog-server/src/main/java/com/airbnb/plog/server/commands/FourLetterCommand.java

  • Replaced Feature Flag Usage

• plog-server/src/main/java/com/airbnb/plog/server/commands/FourLetterCommandHandler.java

  • Replaced Feature Flag Usage (6 times)
  • Cleaned up code (16 times)
    • Deleted the unused function pong
    • Deleted the unused function reply
    • Deleted the unused variable PONG_BYTES
    • Deleted the unused variable packet
    • Deleted the unused variable payload
    • Deleted the unused variable reply
    • Deleted the unused variable trail
    • Propagated the value true to uses of the variable payload
    • Propagated the value true to uses of the variable reply
    • Simplified control flow (4 times)
    • Deleted unused imports (3 times)

• plog-server/src/main/java/com/airbnb/plog/server/fragmentation/Defragmenter.java

  • Replaced Feature Flag Usage (15 times)
  • Cleaned up code (27 times)
    • Deleted the unused function handleMultiFragment
    • Deleted the unused variable computedHash
    • Deleted the unused variable holeConfig
    • Deleted the unused variable message
    • Deleted the unused variable payload
    • Propagated the value true to uses of the variable holeConfig
    • Propagated the value true to uses of the variable payload (3 times)
    • Simplified control flow (15 times)
    • Simplified boolean expressions
    • Deleted unused imports (2 times)

• plog-server/src/main/java/com/airbnb/plog/server/listeners/Listener.java

  • Replaced Feature Flag Usage (9 times)
  • Cleaned up code (9 times)
    • Deleted the unused variable providerName
    • Propagated the value true to uses of the variable handler (2 times)
    • Propagated the value true to uses of the variable providerName (2 times)
    • Simplified control flow (4 times)

• plog-server/src/main/java/com/airbnb/plog/server/packetloss/PortHoleDetector.java

  • Replaced Feature Flag Usage (19 times)
  • Cleaned up code (37 times)
    • Simplified control flow (37 times)

• plog-server/src/main/java/com/airbnb/plog/server/pipeline/ProtocolDecoder.java

  • Replaced Feature Flag Usage (8 times)
  • Cleaned up code (13 times)
    • Deleted the unused variable content
    • Deleted the unused variable trailLength
    • Propagated the value true to uses of the variable content
    • Simplified control flow (9 times)
    • Deleted unused imports

• plog-server/src/test/groovy/com/airbnb/plog/handlers/ReverseBytesProvider.java

  • Replaced Feature Flag Usage
  • Cleaned up code
    • Propagated the value true to uses of the variable reversed