Skip to content

Avoid division-by-zero on 0-weights #7825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Avoid division-by-zero on 0-weights #7825

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0225cfb
Avoid division-by-zero on 0-weights
CISC Jun 7, 2024
e0580f9
Merge branch 'master' of github.com:ggerganov/llama.cpp into quant-di…
CISC Jun 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ggml/src/ggml-quants.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1754,7 +1754,7 @@ static float make_q3_quants(int n, int nmax, const float * restrict x, int8_t *
for (int i = 0; i < n; ++i) {
L[i] += nmax;
}
return sumlx / suml2;
return suml2 ? sumlx / suml2 : 0.0f;
}
for (int i = 0; i < n; ++i) {
int l = nearest_int(iscale * x[i]);
Expand Down Expand Up @@ -2158,7 +2158,7 @@ static float make_qp_quants(int n, int nmax, const float * restrict x, uint8_t *
break;
}
}
return sumlx/suml2;
return suml2 ? sumlx/suml2 : 0.0f;
}

static void quantize_row_q2_K_impl(const float * restrict x, block_q2_K * restrict y, int k, const float * restrict quant_weights) {
Expand Down