Skip to content

Conversation

@ggerganov
Copy link
Member

ref #2321

Clear KV cache from previous chunk when running Hellaswag

@JianbangZ
Copy link

Working now. Hellaswag score for MIstral-7B-v0.1 is 81, same as what's officially reported.

Copy link
Contributor

@ikawrakow ikawrakow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works, but the result is very slightly different from running #4982. Why?

@ikawrakow ikawrakow mentioned this pull request Jan 16, 2024
@ggerganov
Copy link
Member Author

Not 100% sure. In general, evaluating a prompt "[a][b]" where [a] and [b] are some arrays of tokens, will produce slightly different results compared to first evaluating "[a]" and then "[b]", but I'm not sure if it's enough to explain the variation that you observe

@ggerganov ggerganov merged commit 959ef0c into master Jan 16, 2024
@ggerganov ggerganov deleted the gg/hellaswag-clear-kv-cache branch January 16, 2024 17:34
jordankanter pushed a commit to jordankanter/llama.cpp that referenced this pull request Feb 3, 2024
hodlen pushed a commit to hodlen/llama.cpp that referenced this pull request Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants