Revert "CUDA: add expert reduce kernel (#16857)" #17100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 4146d6a.
am17an
requested review from
JohannesGaessler and
slaren
and removed request for
slaren
github-actions
bot
added
testing
JohannesGaessler
approved these changes
Nov 8, 2025
CISC
reviewed
Nov 8, 2025
| } | ||
|
|
||
| while (current_node < cgraph->n_nodes && cgraph->nodes[current_node]->op == GGML_OP_ADD && | ||
| num_adds < num_views - 1) { |
Collaborator
There was a problem hiding this comment.
This logic doesn't add up, what was the intention here?
Collaborator
Author
There was a problem hiding this comment.
What do you mean? n_expert_used views followed by n_expert_used - 1 adds
Collaborator
There was a problem hiding this comment.
Well, it's a little awkward when n_expert_used is 1 (ie, no add, but cont instead), and I'm not sure you're catering for that?
Collaborator
There was a problem hiding this comment.
I think this also means it will kick in on just mul+view.
Collaborator
Author
There was a problem hiding this comment.
Good point, I'll fix that once I figure out the other problems in this kernel (namely related to the lifetime to the weights buffer)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 4146d6a.
This kernel causes some weird perplexity behavior which I can't explain. I will need to fix it before adding it back again