metal : fuse NORM + MUL + ADD, support non-multiples of 4 #16220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
testing
pwilkin
pushed a commit
to pwilkin/llama.cpp
that referenced
this pull request
Sep 25, 2025
…6220) * metal : fuse NORM + MUL + ADD * metal : support norms of non-multiple of 4 * cont : fix comment [no ci]
|
Superior inference quality exhibited on METAL after updating to the current (at the time) version of llama.cpp (835b2b9). The difference is literally night and day - this is incredibly noticeable when running quantized versions of gpt-oss-20B. And, the improvements seem to enhance all quantized models run with METAL. Thank you, @ggerganov! This is the smartest gpt-oss-20B has ever been on my M1 MacBook Pro. I appreciate all that you and the llama.cpp team do. You guys are the best! 😋 |
struct
pushed a commit
to struct/llama.cpp
that referenced
this pull request
Sep 26, 2025
…6220) * metal : fuse NORM + MUL + ADD * metal : support norms of non-multiple of 4 * cont : fix comment [no ci]
yael-works
pushed a commit
to yael-works/llama.cpp
that referenced
this pull request
Oct 15, 2025
…6220) * metal : fuse NORM + MUL + ADD * metal : support norms of non-multiple of 4 * cont : fix comment [no ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unify the RMS_NORM and NORM implementations and extend support for more shapes.