-
Notifications
You must be signed in to change notification settings - Fork 13.4k
vendors: update miniaudio version #16212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Aaron Teo <[email protected]>
Signed-off-by: Aaron Teo <[email protected]>
@ggerganov So, I think @taronaeo has access to merge this, but how can one tell? |
There is no way to tell - Github UI does not seem to provide information about who has write access. |
Yep I have access to merge. But I'll hold this for another 24 hours just in-case @/ngxson or someone else maintaining the multimodal part of the codebase has any comments to add or found something broken with this vendor file update. |
Ignoring
Will re-trigger these CIs again, except AMX, to check if it's an ephemeral problem |
None of these failures are related to the change here. |
* vendor: update miniaudio.h Signed-off-by: Aaron Teo <[email protected]> * vendor: update miniaudio.h Signed-off-by: Aaron Teo <[email protected]> --------- Signed-off-by: Aaron Teo <[email protected]>
* vendor: update miniaudio.h Signed-off-by: Aaron Teo <[email protected]> * vendor: update miniaudio.h Signed-off-by: Aaron Teo <[email protected]> --------- Signed-off-by: Aaron Teo <[email protected]>
* vendor: update miniaudio.h Signed-off-by: Aaron Teo <[email protected]> * vendor: update miniaudio.h Signed-off-by: Aaron Teo <[email protected]> --------- Signed-off-by: Aaron Teo <[email protected]>
This PR fixes the false positive build warnings for GCC 13.3 and later as seen in (#15925 (comment)) that have been raised due to GCC on s390x being more strict.
Raising this PR first to ensure that this update to
miniaudio.h
does not break any multimodal integrations.Tracking: mackron/miniaudio#1048 #15925