ggml-cpu: clean up s390x SIMD #15855
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request cleans up the s390x SIMD Vector Intrinsics syntax to match the new code for easier readability and understanding. No new feature introduction, but there should be slight performance improvements switching the horizontal summation to the optimised
vec_hsum
.Verified that models F32, F16, Q8_0, Q5_1, Q5_0, Q4_1, Q4_0, Q6_K, Q4_K, Q3_K, IQ4_XS, IQ4_NL still work as intended.
Performance Benchmark
build: 4d49427 (6405)
Note
Tests were conducted on an IBM z17 Mainframe with 40 IFLs (cores) and 128 GB Memory on a shared R&D LPAR.