Fix broken build: require updated pip to support --break-system-packages #15357
Conversation
…based on Ubuntu 24.04 (ggml-org#15005)" This reverts commit e4e9159.
github-actions
bot
added
the
devops
danchev
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the broken Docker build by ensuring compatibility with pip's --break-system-packages flag. The build was failing because older pip versions don't recognize this flag, which was introduced in 2023 as part of PEP 668 to prevent modifications to externally managed Python environments.
- Upgraded pip to the latest version before installing dependencies
- Added the
--break-system-packagesflag to bypass PEP 668 restrictions in containerized environments
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| @@ -60,6 +60,7 @@ RUN apt-get update \ | |||
| git \ | |||
| python3 \ | |||
| python3-pip \ | |||
| && pip install --upgrade pip setuptools wheel \ | |||
There was a problem hiding this comment.
The line continuation backslash is missing at the end of line 63, which will cause the Docker build to fail. Add a backslash () at the end of the line to properly continue the RUN command.
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
Would it be enough to upgrade only the pip package?
There was a problem hiding this comment.
Since the Github Actions for publishing the dockerimage specify the "ubuntu-22.04" base image, I think it's a good idea to remove the "--break-system-packages" option from ".devops/cuda.Dockerfile."
Alternatively, instead of removing the "--break-system-packages" option, I think the base image should be based on "ubuntu-24.04."
More details below.
The "--break-system-packages" option was added on "Aug 15, 2025, 12:45 AM GMT+9" via the following issue and pull request.
At this time, "Ubuntu The "--break-system-packages" option was added because container builds failed when using a base image with "ubuntu-24.04" specified, but the .github/workflows/docker.yml settings specifies a fixed value of "ubuntu-22.04", and the pip installed by python3-pip on ubuntu-22.04 is v22.x.
The "--break-system-packages" option is available in pip v23.1 and later, and installing pip v23.1 or later on "ubuntu-22.04" would likely be a bit of a hassle, and the impact would be significant if the base image were based on "ubuntu-24.04", so for the time being it is probably best to remove the "--break-system-packages" option.
There was a problem hiding this comment.
I apologize for the confusion. To be clear, the Docker build is currently failing not because of the addition of the --break-system-packages flag, but because the same PR/commit that introduced the flag also removed the line:
&& pip install --upgrade pip setuptools wheel \ from .devops/cuda.Dockerfile.
This PR contains two commits:
- A revert of the change that broke the build.
- A separate commit that correctly adds the
--break-system-packagesflag, which was the intended change in the original PR fix compile bug when the BASE_CUDA_DEV_CONTAINER is based on Ubuntu 2… #15005.
Effectively, this PR does not introduce anything new to cuda.Dockerfile; it simply restores a line that was mistakenly removed while still keeping the intended flag addition.
…stem installation) - Updated pip install commands to include the --break-system-packages flag, ensuring compatibility when working with system-managed Python environments (PEP 668). - Note: The --break-system-packages option was introduced in 2023. Ensure pip is updated to a recent version before using this flag. fixes [ggml-org#15004](https://github.com/danchev/llama.cpp/issues/15004)
Description
This PR fixes the broken build caused by the introduction of the --break-system-packages flag in pip.
The flag was introduced in 2023 as part of the implementation of PEP 668, which prevents pip from modifying externally managed Python environments by default.
Docker build currently fails because older versions of pip do not recognize this option.
Changes
Updated pip install commands to include --break-system-packages.
Added a note to ensure pip is upgraded to a recent version before invoking this flag.
Impact
Builds will succeed only when pip >= version supporting --break-system-packages is installed.
Environments running outdated pip will continue to fail until upgraded.