-
Notifications
You must be signed in to change notification settings - Fork 13.2k
Fixes #15247 | Update chat.cpp to support (at least) qwen3 reasoning + tool_choice = required #15248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Fixes #15247 | Update chat.cpp to support (at least) qwen3 reasoning + tool_choice = required #15248
Conversation
All am I sure is that it fixes issues with Qwen3 + reasoning (enabled or disabled)+ tool calling. CC hermes2 contributor : @ochafik |
Back at the office on tuesday, re-reading the PR i might reconsider the logic around thinking_forced_open |
…already opened grammar)
…r accepting piece:`
For a future PR, the following functions needs the same kind of patch :
ready for review @ggerganov Not sure exactly who I should ping as ochafik seems to be busy this week |
Not sure who I should ping |
Same comment as #15019 (comment) This is a smaller change, so I can take a look and merge this, but prefer if we have someone who would take over this part of the code. |
Got it, thanks for keeping me updated ! |
There was this issue that we would not use tool_choice at
required
with reasoning because of forced tool call imposed by grammar.Grammar now allows the model to think first.
Reasoning = big brain
Tool calling = strong arms
Now you can be very smart and very strong
Fixes #15247