Automatic Arch Linux detection #1332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit is a port of a detection method used in koboldcpp's Makefile in order to automatically set the -lcblas option on Arch Linux
SergeAx
approved these changes
May 5, 2023
SergeAx
left a comment
SergeAx
left a comment
There was a problem hiding this comment.
This is legit. Here's the original commit: LostRuins@7ba36c2
prusnak
suggested changes
May 5, 2023
Co-authored-by: Pavol Rusnak <[email protected]>
Co-authored-by: Pavol Rusnak <[email protected]>
prusnak
suggested changes
May 5, 2023
Contributor
prusnak
left a comment
prusnak
left a comment
There was a problem hiding this comment.
Please also test on Arch Linux whether my suggestions work. I don't have one laying around.
Co-authored-by: Pavol Rusnak <[email protected]>
Contributor
Author
|
Like this it works perfectly on Arch Linux. Sorry for the mess with the commits but it's my first time editing a Makefile. |
prusnak
approved these changes
May 5, 2023
Contributor
No worries, you did great and I really like the final form of the submission! 🎉 |
Collaborator
|
Nice 👍 |
KerfuffleV2
pushed a commit
to KerfuffleV2/llama.cpp
that referenced
this pull request
May 6, 2023
This commit is a port of a detection method used in koboldcpp's Makefile in order to automatically set the -lcblas option on Arch Linux
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a check in the Makefile in order to set automatically the -lcblas flag on Arch Linux. This change is based on koboldcpp's Makefile so the credit for this should go to @LostRuins.