Skip to content

Conversation

@lslusarczyk
Copy link
Contributor

  1. Fixed deprecated intel::reqd_sub_group_size, see llvm release notes: Deprecated intel::reqd_sub_group_size, the official SYCL 2020 spelling should be used instead (with sycl:: namespace).
  2. Added static keyword to functions which symbols do not need to be exported
  3. Removed excessive, non-reachable break statements.

These are warnings issued by latest llvm compiler.

@github-actions github-actions bot added ggml changes relating to the ggml tensor library for machine learning SYCL https://en.wikipedia.org/wiki/SYCL - GPU programming language labels Mar 17, 2025
@lslusarczyk lslusarczyk marked this pull request as ready for review March 17, 2025 14:15
@Alcpz Alcpz changed the title fixed compilation warnings in ggml-sycl sycl: fixed compilation warnings Mar 17, 2025
Copy link
Collaborator

@NeoZhangJianyu NeoZhangJianyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's OK to update the code to rm the warning for next release compiler.
We only use the stable compiler in official oneAPI package.

It's great if optimize OPs or implement unsupported OPs.

Thank you!

@NeoZhangJianyu NeoZhangJianyu merged commit a53f7f7 into ggml-org:master Mar 18, 2025
47 checks passed
arthw pushed a commit to arthw/llama.cpp that referenced this pull request Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ggml changes relating to the ggml tensor library for machine learning SYCL https://en.wikipedia.org/wiki/SYCL - GPU programming language

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants