Skip to content

llama : fix progress dots #11730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 7, 2025
Merged

llama : fix progress dots #11730

merged 2 commits into from
Feb 7, 2025

Conversation

@magicse
Copy link
Contributor

@magicse magicse commented Feb 7, 2025 •
edited
Loading

The progress dots were not displayed during model loading in the new version, and this fix restores the expected behavior.

load_tensors:      Vulkan0 model buffer size =  4306.97 MiB
load_tensors:   CPU_Mapped model buffer size =  6828.77 MiB
llama_init_from_model: n_seq_max     = 1
llama_init_from_model: n_ctx         = 4096
llama_init_from_model: n_ctx_per_seq = 4096

Fixed the progress dot display during model loading. ilke this

load_tensors:      Vulkan0 model buffer size =  4306.97 MiB
load_tensors:   CPU_Mapped model buffer size =  6828.77 MiB
...................................................................................................
llama_init_from_model: n_seq_max     = 1
llama_init_from_model: n_ctx         = 4096
llama_init_from_model: n_ctx_per_seq = 4096

Make sure to read the contributing guidelines before submitting a PR

@magicse
Update llama.cpp
1caedde 
For display progress dots in terminal.
Without this it didn't display dots progress during loading model from file.
@magicse
Update llama.cpp
72a78b8 
removed trailing spaces
@ngxson ngxson changed the title Update llama.cpp llama : fix progress dots Feb 7, 2025
@ggerganov ggerganov merged commit 333820d into ggml-org:master Feb 7, 2025
46 checks passed
tinglou pushed a commit to tinglou/llama.cpp that referenced this pull request Feb 13, 2025
@magicse @tinglou
llama : fix progress dots (ggml-org#11730)
82c75cb 
* Update llama.cpp

For display progress dots in terminal.
Without this it didn't display dots progress during loading model from file.

* Update llama.cpp

removed trailing spaces
orca-zhang pushed a commit to orca-zhang/llama.cpp that referenced this pull request Feb 26, 2025
@magicse @orca-zhang
llama : fix progress dots (ggml-org#11730)
40fda23 
* Update llama.cpp

For display progress dots in terminal.
Without this it didn't display dots progress during loading model from file.

* Update llama.cpp

removed trailing spaces
arthw pushed a commit to arthw/llama.cpp that referenced this pull request Feb 26, 2025
@magicse @NeoZhangJianyu
llama : fix progress dots (ggml-org#11730)
379f703 
* Update llama.cpp

For display progress dots in terminal.
Without this it didn't display dots progress during loading model from file.

* Update llama.cpp

removed trailing spaces
mglambda pushed a commit to mglambda/llama.cpp that referenced this pull request Mar 8, 2025
@magicse @mglambda
llama : fix progress dots (ggml-org#11730)
c80a55d 
* Update llama.cpp

For display progress dots in terminal.
Without this it didn't display dots progress during loading model from file.

* Update llama.cpp

removed trailing spaces
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@slaren slaren slaren approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@magicse @slaren @ggerganov