-
Notifications
You must be signed in to change notification settings - Fork 12.4k
tool-call
: fix llama 3.x and functionary 3.2, play nice w/ pydantic_ai package, update readme
#11539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f597c5a
to
e58ff54
Compare
tool-call
: small fixes to play nice w/ pydantic_ai packagetool-call
: small fixes to play nice w/ pydantic_ai package (+ update readme)
tool-call
: small fixes to play nice w/ pydantic_ai package (+ update readme)tool-call
: fix llama 3.x and functionary 3.2, play nice w/ pydantic_ai package, update readme
e58ff54
to
fa20249
Compare
41 tasks
ggerganov
approved these changes
Jan 31, 2025
Co-authored-by: Georgi Gerganov <[email protected]>
tinglou
pushed a commit
to tinglou/llama.cpp
that referenced
this pull request
Feb 13, 2025
…_ai package, update readme (ggml-org#11539) * An empty tool_call_id is better than none! * sync: minja (tool call name optional google/minja#36) * Force-disable parallel_tool_calls if template doesn't support it * More debug logs * Llama 3.x tools: accept / trigger on more varied spaced outputs * Fix empty content for functionary v3.2 tool call * Add proper tool call docs to server README * readme: function calling *is* supported now * Apply suggestions from code review Co-authored-by: Georgi Gerganov <[email protected]> --------- Co-authored-by: Georgi Gerganov <[email protected]>
I have added a pr to start the discussion of how MCP should be added to the client. Please share your thoughts if you don't mind. #11853 |
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Feb 26, 2025
…_ai package, update readme (ggml-org#11539) * An empty tool_call_id is better than none! * sync: minja (tool call name optional google/minja#36) * Force-disable parallel_tool_calls if template doesn't support it * More debug logs * Llama 3.x tools: accept / trigger on more varied spaced outputs * Fix empty content for functionary v3.2 tool call * Add proper tool call docs to server README * readme: function calling *is* supported now * Apply suggestions from code review Co-authored-by: Georgi Gerganov <[email protected]> --------- Co-authored-by: Georgi Gerganov <[email protected]>
mglambda
pushed a commit
to mglambda/llama.cpp
that referenced
this pull request
Mar 8, 2025
…_ai package, update readme (ggml-org#11539) * An empty tool_call_id is better than none! * sync: minja (tool call name optional google/minja#36) * Force-disable parallel_tool_calls if template doesn't support it * More debug logs * Llama 3.x tools: accept / trigger on more varied spaced outputs * Fix empty content for functionary v3.2 tool call * Add proper tool call docs to server README * readme: function calling *is* supported now * Apply suggestions from code review Co-authored-by: Georgi Gerganov <[email protected]> --------- Co-authored-by: Georgi Gerganov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bugfix
fixes an issue or bug
documentation
Improvements or additions to documentation
examples
server
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes more models to play nice w/ pydantic agent (follow up from #9639)
Chat format:
even w/o--verbose
Example test code from @brucepro (ref):