convert-lora : make --base optional
#10110
Merged
+51
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compilade
approved these changes
Nov 1, 2024
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Nov 15, 2024
* convert-lora : make `--base` optional * lint * handle case where base_model_name_or_path is invalid * do not include metadata from base model * clarify unspecified --base * add small comment [no ci] * trigger ci
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Nov 18, 2024
* convert-lora : make `--base` optional * lint * handle case where base_model_name_or_path is invalid * do not include metadata from base model * clarify unspecified --base * add small comment [no ci] * trigger ci
|
--base is still listed when you call -h for help |
Collaborator
Author
|
it's optional, not removed |
|
yeah my notes got me confused. sorry
-------- Original message --------From: Xuan Son Nguyen ***@***.***> Date: 12/26/24 12:34 PM (GMT-10:00) To: "ggerganov/llama.cpp" ***@***.***> Cc: Jonathan Humphries ***@***.***>, Comment ***@***.***> Subject: Re: [ggerganov/llama.cpp] convert-lora : make `--base` optional (PR #10110)
it's optional, not removed
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
convert_lora_to_gguf.py, the--baseis solely to specify the path to base modelconfig.json. The base weight is never used, so it's kinda waste.This PR make
--baseoptional by using"base_model_name_or_path"insideadapter_config.jsonTested with https://huggingface.co/grimjim/Llama-3-Instruct-abliteration-LoRA-8B/tree/main