Assert on swapchain output usage before presenting #151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grovesNL
approved these changes
May 6, 2019
bors bot
added a commit
that referenced
this pull request
May 6, 2019
151: Assert on swapchain output usage before presenting r=grovesNL a=kvark Fixes #148 There is no "fix" for the case on our side. The PR brings stronger requirements on the swapchain outputs: they have to be used and submitted before dropped. Co-authored-by: Dzmitry Malyshau <[email protected]>
Build succeeded |
mitchmindtree
pushed a commit
to mitchmindtree/wgpu
that referenced
this pull request
Feb 23, 2020
151: Add Lyon to the friends list r=kvark a=Veykril Closes gfx-rs#84 Co-authored-by: Lukas Wirth <[email protected]>
kvark
pushed a commit
to kvark/wgpu
that referenced
this pull request
Jun 3, 2021
151: Add Lyon to the friends list r=kvark a=Veykril Closes gfx-rs#84 Co-authored-by: Lukas Wirth <[email protected]>
RandyMcMillan
pushed a commit
to RandyMcMillan/wgpu
that referenced
this pull request
Jun 19, 2024
Make layout bounds explicit in `UserInterface`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #148
There is no "fix" for the case on our side. The PR brings stronger requirements on the swapchain outputs: they have to be used and submitted before dropped.