fix(sourcemapcache): Don't return unmapped source locations #922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loewenheim
commented
May 30, 2025
| let idx = match self.min_source_positions.binary_search(&sp.into()) { | ||
| Ok(idx) => idx, | ||
| Err(0) => 0, | ||
| Err(0) => return None, |
There was a problem hiding this comment.
@Swatinem can you think of a reason it would make sense to return 0 here? Surely the Err(0) case means our input location is unmapped?
Swatinem
approved these changes
Jun 2, 2025
Will do, but it might take a bit until I get around to it. |
Swatinem
approved these changes
Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't do anything without getsentry/rust-sourcemap#129, but is sound even without it.