Skip to content

fix(onboarding): Remove sourceMapUploadOptions from Astro #99371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 15, 2025
Merged

fix(onboarding): Remove sourceMapUploadOptions from Astro #99371

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions static/app/gettingStartedDocs/javascript/astro.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ describe('javascript-astro onboarding docs', () => {
).not.toBeInTheDocument();
});

it('shows only sourceMapsUploadOptions in astro.config.mjs', () => {
it('shows only build-time options in astro.config.mjs', () => {
renderWithOnboardingLayout(docs, {
selectedProducts: [
ProductSolution.ERROR_MONITORING,
Expand All @@ -184,9 +184,9 @@ describe('javascript-astro onboarding docs', () => {
],
});

// astro.config.mjs should only contain sourceMapsUploadOptions
// astro.config.mjs should only contain build-time options
expect(
screen.getByText(textWithMarkupMatcher(/sourceMapsUploadOptions/))
screen.getByText(textWithMarkupMatcher(/process.env.SENTRY_AUTH_TOKEN/))
).toBeInTheDocument();

// Runtime config should NOT be in astro.config.mjs anymore
Expand Down
16 changes: 6 additions & 10 deletions static/app/gettingStartedDocs/javascript/astro.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,11 +39,9 @@ import sentry from "@sentry/astro";
export default defineConfig({
integrations: [
sentry({
sourceMapsUploadOptions: {
project: "${params.project.slug}",
org: "${params.organization.slug}",
authToken: process.env.SENTRY_AUTH_TOKEN,
},
project: "${params.project.slug}",
org: "${params.organization.slug}",
authToken: process.env.SENTRY_AUTH_TOKEN,
}),
],
});
Expand Down Expand Up @@ -407,11 +405,9 @@ import sentry from "@sentry/astro";
export default defineConfig({
integrations: [
sentry({
sourceMapsUploadOptions: {
project: "${params.project.slug}",
org: "${params.organization.slug}",
authToken: process.env.SENTRY_AUTH_TOKEN,
},
project: "${params.project.slug}",
org: "${params.organization.slug}",
authToken: process.env.SENTRY_AUTH_TOKEN,
}),
],
});
Expand Down
Loading