ref(suspect commits): Simplify event file committers to GroupOwner-only behavior #98504
+174
−838
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes the legacy release-based fallback logic from the event file committers endpoint, simplifying it to use only GroupOwner-based suspect commit detection.
There are currently 2 suspect commit assessment strategies, both create a GroupOwner for the Group if they find a good suspect commit. These changes mean that only GroupOwners created during original analysis will be retuned for the Issue.
While my intention has been to create fewer but better suspect commits, with the logic in this function it meant I was actually displaying a lot more legacy strategy suspect commits, which is not what I want.
Changes Made
Core Logic Changes
get_serialized_event_file_committers
now only calls_get_serialized_committers_from_group_owners
suspectCommitStrategy
from GroupOwner context instead of hardcodingINTEGRATION_COMMIT
RELEASE_BASED
→"via commit in release"
SCM_BASED
→"via SCM integration"
Behavior Changes
Before
After