🐛 fix(aci): fix slack interactions during rollout #98503
Merged
+39
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves SENTRY-48VA
basically because we are rolling out ACI, when we try to build a notification using Rules, we must populate the "legacy_rule_id" field. we weren't doing that so when we went to send a notification, we were erroring out (since we were going down the aci backend rollout path).
this pr fixes it by correctly inserting the
legacy_rule_id
key, similar tosentry/src/sentry/notifications/notification_action/types.py
Line 168 in db7de1e
also wrote a test to verify this behavior.