Skip to content

Conversation

iamrajjoshi
Copy link
Member

resolves SENTRY-48VA

basically because we are rolling out ACI, when we try to build a notification using Rules, we must populate the "legacy_rule_id" field. we weren't doing that so when we went to send a notification, we were erroring out (since we were going down the aci backend rollout path).

this pr fixes it by correctly inserting the legacy_rule_id key, similar to

data["actions"][0]["legacy_rule_id"] = alert_rule_workflow.rule_id

also wrote a test to verify this behavior.

@iamrajjoshi iamrajjoshi self-assigned this Aug 29, 2025
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Aug 29, 2025
@iamrajjoshi iamrajjoshi marked this pull request as ready for review August 29, 2025 00:31
@iamrajjoshi iamrajjoshi requested review from a team as code owners August 29, 2025 00:31
Copy link

codecov bot commented Aug 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #98503      +/-   ##
==========================================
+ Coverage   81.13%   81.18%   +0.04%     
==========================================
  Files        8541     8544       +3     
  Lines      376472   376570      +98     
  Branches    23952    23952              
==========================================
+ Hits       305441   305703     +262     
+ Misses      70666    70502     -164     
  Partials      365      365              

Copy link
Contributor

@Christinarlong Christinarlong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rtust u bro

@iamrajjoshi iamrajjoshi merged commit 06cff32 into master Sep 2, 2025
65 checks passed
@iamrajjoshi iamrajjoshi deleted the raj/aci/fix-slack-interactions branch September 2, 2025 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants