Skip to content

Conversation

cvxluo
Copy link
Contributor

@cvxluo cvxluo commented Aug 28, 2025

Follow up to #97148 — we had to do some hacky things so that upsell banners worked properly while moving features to flagpole. Now that cross-project selection (aka global-views) is enabled for all plans, we need to clean up this workaround. Next steps are to deprecate global-views entirely.

Closes https://linear.app/getsentry/issue/ID-861/remove-global-views-hovercard-hack-once-logs-launches

Copy link

linear bot commented Aug 28, 2025

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Aug 28, 2025
if (!plan.features.includes('global-views')) {
plan.features.push('global-views');
}
}
if (isBizPlanFamily(plan)) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@narsaynorath i saw you also have dashboard-related flags here — are these safe to clean up as well?

@cvxluo cvxluo marked this pull request as ready for review August 28, 2025 22:29
@cvxluo cvxluo requested review from a team August 28, 2025 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant