chore(integrations): Use installableOnly option to filter down integration repos
#98497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to filter down repos, if needed
github-actions
bot
added
the
Scope: Backend
…oint-accept-installable-only-param
cathteng
approved these changes
Aug 28, 2025
| serialized_repositories = [ | ||
| IntegrationRepository( | ||
| name=repo["name"], | ||
| identifier=repo["identifier"], | ||
| defaultBranch=repo.get("default_branch"), | ||
| ) | ||
| for repo in repositories | ||
| if repo["identifier"] not in repo_names | ||
| if not installable_only or repo["identifier"] not in installed_repo_names |
There was a problem hiding this comment.
nit: this was a little hard for me to grok. Could we add a comment to explain?
| @@ -65,14 +66,16 @@ def get( | |||
| except (IntegrationError, IdentityNotValid) as e: | |||
| return self.respond({"detail": str(e)}, status=400) | |||
|
|
|||
| installable_only = request.GET.get("installableOnly", "false").lower() == "true" | |||
There was a problem hiding this comment.
Usually if you are just passing a boolean query param, you can just check for the existence of the param to apply it
Suggested change
| installable_only = request.GET.get("installableOnly", "false").lower() == "true" | |
| installable_only = request.GET.get("installableOnly") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of ID-125.
Follow-up to #98491.
Adds the
installableOnlyquery param toOrganizationIntegrationReposEndpointto determine whether or not to filter down integration repos returned. Default behavior (installableOnlynot passed or passed as non-true) is to return all repos made available by the integration.