fix(asana): filter out unsafe query strings in oauth initiation request #98496
+44
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #98496 +/- ##
==========================================
- Coverage 80.73% 80.61% -0.12%
==========================================
Files 8604 8620 +16
Lines 381301 380757 -544
Branches 24710 24710
==========================================
- Hits 307846 306954 -892
- Misses 73077 73425 +348
Partials 378 378 |
leeandher
reviewed
Aug 29, 2025
Comment on lines
+81
to
+101
| def _get_safe_query_string(self): | ||
| """ | ||
| Returns filtered query string without client_id parameter. | ||
| """ | ||
|
|
||
| query_string = self.request.META.get("QUERY_STRING", "") | ||
| if not query_string: | ||
| return "" | ||
|
|
||
| parsed_params = parse_qsl(query_string, keep_blank_values=True) | ||
| safe_params = [] | ||
|
|
||
| for param_name, param_value in parsed_params: | ||
| # Remove client_id parameter | ||
| if param_name.lower() != "client_id": | ||
| safe_params.append((param_name, param_value)) | ||
|
|
||
| if safe_params: | ||
| return "&" + urlencode(safe_params) | ||
| else: | ||
| return "" |
There was a problem hiding this comment.
Rather than implement this just for asana, I think it'd be fine to make the change on the base class (BaseOAuth2). The other implementations are both deprecated, and it'd avoid us having to redeclare auth_url.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
overriding the
auth_urlmethod from thebaseOAuth2class to filter out the unsafeclient_idquery stringfixes https://linear.app/getsentry/issue/RTC-1114/oauth-manipulation-in-sentrys-asana-integration-leading-to-account